[#1843] [AMQ-9687] Add metrics about error and reconnect counts to network co…#1726
Open
mattrpav wants to merge 1 commit into
Open
[#1843] [AMQ-9687] Add metrics about error and reconnect counts to network co…#1726mattrpav wants to merge 1 commit into
mattrpav wants to merge 1 commit into
Conversation
mattrpav
changed the title
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
github-project-automation
Bot
moved this from In progress
to Done
in Apache ActiveMQ v6.3.0
…nnector and network bridges
cshannon
requested changes
Jul 16, 2026
| private final ExecutorService syncExecutor = Executors.newSingleThreadExecutor(); | ||
| private Transport duplexInboundLocalBroker = null; | ||
| private ProducerInfo duplexInboundLocalProducerInfo; | ||
| private AtomicLong startedTimestamp = new AtomicLong(0L); |
Contributor
There was a problem hiding this comment.
Suggested change
| private AtomicLong startedTimestamp = new AtomicLong(0L); | |
| private final AtomicLong startedTimestamp = new AtomicLong(0L); |
| // Once we have all required broker info we can attempt to start | ||
| // the local and then remote sides of the bridge. | ||
| doStartLocalAndRemoteBridges(); | ||
| startedTimestamp.set(System.currentTimeMillis()); |
Contributor
There was a problem hiding this comment.
I would move this to the start() method just because the other call to set back to 0 is in the stop() method so it makes more sense. I'd also add it to a try/finally probably. Here is what i mean.
Something like:
try {
triggerStartAsyncNetworkBridgeCreation();
} catch (IOException e) {
LOG.warn("Caught exception from remote start", e);
} finally {
startedTimestamp.set(System.currentTimeMillis());
}| throw new IllegalStateException("You must configure the 'localURI' property"); | ||
| } | ||
| LOG.info("Network Connector {} started", this); | ||
| bridgeExceptionCounter.setEnabled(true); |
Contributor
There was a problem hiding this comment.
Shouldn't this not be true by default? I thought network statistics were optional and configurable?
| public void resetStats(){ | ||
| next.resetStats(); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nnector and network bridges
ref: [#1843]
ref: [AMQ-9687]