Go SDK: add dag.If with Then and Else so native Dags can branch - #74075
Merged
Merged
Conversation
FrankYang0529
marked this pull request as ready for review
October 2, 2026 09:03
FrankYang0529
requested review from
amoghrajesh,
ashb and
jason810496
as code owners
October 2, 2026 09:03
jason810496
reviewed
Oct 2, 2026
jason810496
left a comment
Member
There was a problem hiding this comment.
Nice, thanks.
No major finding from me, here're the comments caught by the Claude reivew.
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
airflow-go-sdk-dag-if
branch
from
October 3, 2026 08:18
699f495 to
f023213
Compare
1 task done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Go SDK: Add dag.If with Then and Else.
dag.If(fn, opts...)returns an*airflow.IfRefand adds a task that runs the condition functionfn.fnreturns(bool, error). It follows the same rules as a function passed todag.Task.IfRef.ThenandIfRef.Elsetake the*airflow.TaskRefof the task to run on each side.fnreturnstrue, the condition task skips the task fromElse. Whenfnreturnsfalse, the condition task skips the task fromThen. Whenfnreturns an error, the condition task fails.fnruns, the condition task writes{"skipped": []}to theskipmixin_keyXCom.NotPreviouslySkippedDepreads that XCom when someone clears a skipped task. The Go runtime does not delete the XComs of earlier tries. Without the empty list, a list from an earlier try could skip a task that the current try did not skip. When the condition task skips a task, it first writes the task_id of that task to theskipmixin_keyXCom and then sendsSkipDownstreamTasks.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.