Conversation
shahar1
force-pushed
the
drop-py310/3-compat-shims
branch
from
October 3, 2026 13:07
cc92bc4 to
3071727
Compare
shahar1
added this pull request to stack #74160
October 3, 2026 13:08
1 task done
shahar1
force-pushed
the
drop-py310/3-compat-shims
branch
from
October 3, 2026 13:38
3071727 to
8b364cb
Compare
shahar1
marked this pull request as ready for review
October 3, 2026 13:51
shahar1
requested review from
Lee-W,
amoghrajesh,
ashb,
bolkedebruin,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil,
potiuk and
vatsrahul1001
as code owners
October 3, 2026 13:51
shahar1
force-pushed
the
drop-py310/3-compat-shims
branch
from
October 3, 2026 15:00
8b364cb to
af79df4
Compare
CI no longer runs Python 3.10, so the tomli fallbacks for tomllib, the typing_extensions imports of Self, Unpack and assert_never, the re-implementation of asyncio.Runner in the Task SDK and the version gated test skips no longer have a version to serve.
shahar1
force-pushed
the
drop-py310/3-compat-shims
branch
from
October 3, 2026 20:05
af79df4 to
48ba311
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My favorite PR in the series so far - this PR removes all 3.10 compatibility shims.
related: #74148
AI Summary
CI no longer runs Python 3.10 (layer 1) and the prek hooks run on 3.11 (layer 2), so these shims have no version left to serve:tomlifallbacks replaced by plaintomllibimports in breeze and the docs build. The same change in the prek scripts,dev/registryanddocker-testsis deferred to layer 7:tomllibonly sorts as a stdlib import once theirpyproject.tomlsays 3.11, so doing it here would trip isort (I001).typing_extensionsimports ofSelf,Unpack,assert_neverintyping_compat,shared/dagnodeandshared/observabilityreplaced bytyping.BaseOperator.event_loop()usesasyncio.Runnerdirectly; the 3.10 re-implementation and its_cancel_all_taskshelper are removed, and the test fixture that exercised the fallback goes with them.sys.version_info < (3, 11)test skips removed; comments that explained 3.10-specificisinstance(list[X], type)behaviour rewritten.Stack
Layer 3 of 9 of the Python 3.10 drop (supersedes #74144, which carried the whole change in one PR). Each layer is meant to be green on its own: the script metadata bump comes first because prek picks the hook interpreter from it, and the ruff fixes land before the
requires-pythonbump because ruff infers its target per distribution from the nearestpyproject.toml.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5.1) following the guidelines