Repository navigation
Conversation
…ptions "serializing X to StructScalar" exposed an internal detail and read like a bug when running acero_register_example. State that only built-in options types can be serialized, and label the expected failure in the example output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
|
Thanks for opening a pull request! This pull request has been automatically closed because you currently have 9 open pull requests, which is more than the limit of 3. Due to the increase in pull requests opened by AI bots, and in order to keep the review queue manageable, Apache Arrow limits contributors without repository access to at most 3 concurrently open pull requests. This helps make sure each pull request gets the attention it needs and that work in progress does not go stale. Once one of your other open pull requests has been merged or closed, you are welcome to reopen this one. See also: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
"serializing X to StructScalar" exposed an internal detail and read like
a bug when running acero_register_example. State that only built-in
options types can be serialized, and label the expected failure in the
example output.
What changes are included in this PR?
cpp/examples/arrow/acero_register_example.cccpp/src/arrow/compute/function_internal.ccAre these changes tested?
Yes. A regression test in
cpp/src/arrow/compute/expression_test.ccfails without the change and passes with it; the surrounding test module/binary passes.Are there any user-facing changes?
See the rationale above.
Was AI used for this PR?
This PR is a joint contribution from Nilanjan Chatterjee (@nil68657) and Claude (Claude Opus 5.5, via Claude Code). Nilanjan chose the issue and directed the work; Claude reproduced the bug, wrote the fix, the test and this description.
PR code and description written by:
Reviewed before submission by: