Repository navigation
Conversation
…trailing newline The dataset JSON reader derived the physical schema from the complete lines of the first block only. A file holding one object without a newline produced an empty schema, so every column was read as null. Parse the whole block when it already covers the entire file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Member
|
Thanks for the PR. I’m closing it because Arrow’s contributor guidelines require that AI-generated code be reviewed and understood by the person submitting it:
Once you’ve reviewed the changes and can own them yourself, you’re welcome to open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The dataset JSON reader derived the physical schema from the complete
lines of the first block only. A file holding one object without a
newline produced an empty schema, so every column was read as null.
Parse the whole block when it already covers the entire file.
What changes are included in this PR?
cpp/src/arrow/dataset/file_json.ccAre these changes tested?
Yes. A regression test in
cpp/src/arrow/dataset/file_json_test.ccfails without the change and passes with it; the surrounding test module/binary passes.Are there any user-facing changes?
See the rationale above.
Was AI used for this PR?
This PR is a joint contribution from Nilanjan Chatterjee (@nil68657) and Claude (Claude Opus 5.5, via Claude Code). Nilanjan chose the issue and directed the work; Claude reproduced the bug, wrote the fix, the test and this description.
PR code and description written by:
Reviewed before submission by: