Repository navigation
Conversation
…ength is taken only once its NUL has arrived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The STOMP 1.1 and 1.2 decoders (
StompDecoderV11.parseBodyand its copy inStompDecoderV12), given acontent-length, took the frame once the buffer held the body and one more byte, then skipped ahead to the NUL. When bytes followed the body before the NUL and the buffer ended before that NUL, the frame was returned anyway, and the rest of it, arriving in the next packet, was parsed as the next frame's command: the client gotAMQ339023 Invalid STOMP frame. In one packet the same bytes were accepted, so whether such a frame went through depended on how TCP split it.Both decoders now look for the NUL first and wait for more bytes until it is there, as they already do for a frame without
content-length.StompV11TestandStompV12Test.testFrameEndingInALaterPacketThanItsContentLengthBodysend a frame withcontent-length:5and the body plus one byte, then the rest up to the NUL in a second write, then another frame, and check both receipts and both messages. They fail without the fix.https://issues.apache.org/jira/browse/ARTEMIS-6359