refactor(internal): lift panic-safe fan-out waking - #260
Merged
Conversation
wake_all is shared by WaitSet, WaitList, countdown, and semaphore-backed primitives, so keeping it inside waitset couples unrelated feature builds to the waiter arena. Move the helper to the internal module boundary and restrict waitset compilation to features that actually use WaitSet or WakerToken. Signed-off-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wake_allhelper frominternal::waitsetto the internal module boundarycrate::internal::wake_allwaitsetonly for features that useWaitSetorWakerTokenDesign Notes
wake_allis shared by wait sets, wait lists, countdown state, and semaphore-backed primitives. Keeping it underwaitsetmade unrelated feature builds compile the waiter arena solely to access the helper. This change restores the module boundary without changing behavior or public API.Validation
cargo x checkcargo x testcargo x lint