ci: link discussions to mailing list threads - #263
Merged
Conversation
Xuanwo
marked this pull request as ready for review
September 1, 2026 04:47
Comment on lines
+149
to
+150
| emails.find(email => normalizeSubject(email.subject) === normalizedTitle) || | ||
| emails[0]; |
Contributor
There was a problem hiding this comment.
Falling back to the 1st email in the result seems not make sense. When could it happen?
Contributor
There was a problem hiding this comment.
It seems that it happened only when an incorrect discussion title was added. In this case, I tend to just fail instead of returning the 1st search result.
| } | ||
|
|
||
| async function runAsfml(args) { | ||
| const { stdout } = await execFileAsync('npx', ['--yes', 'asfml', ...args], { |
Contributor
There was a problem hiding this comment.
It would be better to pin asfml's version in case of security attack, though I confirmed it's maintained by yourself :)
Suggested change
| const { stdout } = await execFileAsync('npx', ['--yes', 'asfml', ...args], { | |
| const { stdout } = await execFileAsync('npx', ['--yes', 'asfml@0.1.1', ...args], { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configure stable subjects for GitHub Discussion notifications and add a workflow that resolves each mirrored
dev@asyncband.apache.orgthread throughasfmland comments the archive URL back on the Discussion. The workflow also supports manual backfill for existing Discussions.