Repository navigation
Conversation
lyne7-sc
changed the title
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
1 open issue
What changed in this PR
This PR fixes unnecessary whole-expression JVM fallback during single-child expression fallback by preserving Literal parameters so parent converters can still inspect constants and remain native (e.g., TPC-DS Q2 projection).
Changes:
- Preserve
Literalchildren when wrapping expressions under the single-child fallback path. - Add a regression test covering
round(a / b, 2)staying native while the unsupported child falls back. - Update the Spark 3.5 TPC-DS Q2 golden physical plan to reflect the improved native projection.
| File | Description |
|---|---|
| spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala | Avoids wrapping Literal children in NativeExprWrapper during single-child fallback to preserve constant-pattern matching in converters. |
| spark-extension-shims-spark/src/test/scala/org/apache/auron/AuronExpressionSuite.scala | Adds a regression test to ensure literal parameters are preserved during fallback and the projection remains native. |
| dev/auron-it/src/main/resources/tpcds-plan-stability/spark-3.5/q2.txt | Updates the expected plan output for TPC-DS Q2 after the fallback behavior change. |
Review effort: Lite
Comment on lines
358
to
371
| val childrenConverted = sparkExpr.mapChildren { | ||
| // Preserve literal parameters when wrapping child expressions. | ||
| case literal: Literal => literal | ||
| case child => | ||
| try { | ||
| val converted = | ||
| convertExprWithFallback(child, isPruningExpr = false, fallbackToError) | ||
| Shims.get.createNativeExprWrapper(converted, child.dataType, child.nullable) | ||
| } catch { | ||
| case _: NotImplementedError => | ||
| val fallbacked = convertExpr(child) | ||
| Shims.get.createNativeExprWrapper(fallbacked, child.dataType, child.nullable) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Updated the code to preserve literals only after successful conversion. Children that throw NotImplementedError continue through the existing fallback path.
Copilot stopped reviewing on behalf of
slfan1989 due to an error
October 21, 2026 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2588
Rationale for this change
When exactly one child expression needs fallback, Auron also wraps literal parameters in unevaluable
NativeExprWrapperobjects. Parent expressions that read these constants during conversion can fail to convert, causing unnecessary fallback. In TPC-DS Q2, this makes the entire projection fall back to Spark.What changes are included in this PR?
Preserve literal parameters when wrapping child expressions.
Are there any user-facing changes?
Affected projections can remain native while unsupported child expressions still use JVM fallback. Query results and public APIs are unchanged.
How was this patch tested?
AuronExpressionSuite, verifying correct results and native projection.Was this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: OpenAI Codex (GPT-6)ASF guidance: https://www.apache.org/legal/generative-tooling.html