AVRO-4228: [c++] Fix BinaryDecoder::arrayNext() to handle negative block counts (branch-1.12 backport) - #3950
Open
iemejia wants to merge 1 commit into
Open
Conversation
…ock counts (apache#3646) * AVRO-4228: Fix BinaryDecoder::arrayNext() to handle negative block counts * AVRO-4228: Add test for arrayNext() with negative block counts * AVRO-4228: Move negative block count to second block in test * AVRO-4228: Avoid undefined behavior when negating INT64_MIN in doDecodeItemCount --------- Co-authored-by: Gabriel Feyer <gabriel.feyer@indexexchange.com> (cherry picked from commit 3508f0e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3646 (commit
3508f0ec8d) tobranch-1.12.BinaryDecoder::arrayNext()calleddoDecodeLong()directly instead ofdoDecodeItemCount(), so it mishandled negative array/map block counts. Per the Avro spec a negative block count means the absolute value is the item count, followed by a long block byte-size;doDecodeItemCount()handles that (and avoids UB when negatingINT64_MIN), and is already used byarrayStart()/mapStart().This is the reason AVRO-4228 was reopened — the fix landed on
mainbut was not cherry-picked tobranch-1.12. Cherry-pick applies cleanly; C++CodecTests(incl. the added negative-block-count test) pass.JIRA: https://issues.apache.org/jira/browse/AVRO-4228