AVRO-4350: [JavaScript] Restore underscore dependency - #3970
Open
svozza wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
AVRO-4350
Restore Underscore as a production dependency of
avro-js. The deprecated validator is loaded by the package entry point and still requires Underscore, causing clean installations to fail when requiringavro-js.Removing the Underscore usage from the deprecated validator is likely the better long-term solution. Since the currently published package is broken for clean installations, this PR prioritizes restoring the dependency as a small, low-risk fix. Removing the dependency can be handled separately.
Verifying this change
Manually verified by packaging the modified local source, installing the resulting tarball in a clean project, and successfully running:
node -e "require('avro-js')"The JavaScript test suite and lint task also pass.
Documentation