You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to take this one too (I'm doing #18691 in #40865). DatastoreV1Test can't move to TestPipeline: the fns under test hold Mockito mocks from mockDatastoreFactory, which can't be serialized, and the tests check those mocks after the bundle runs. That's why every call sets DO_NOT_CLONE today. My plan is a small processBundle(fn, inputs) helper in the test that runs the fn in-process through DoFnRunners.simpleRunner, and to swap the 10 DoFnTester call sites over to it.
Activity
Rishavbhattarai commentedon Oct 28, 2026
.take-issue
I'd like to take this one too (I'm doing #18691 in #40865).
DatastoreV1Testcan't move toTestPipeline: the fns under test hold Mockito mocks frommockDatastoreFactory, which can't be serialized, and the tests check those mocks after the bundle runs. That's why every call setsDO_NOT_CLONEtoday. My plan is a smallprocessBundle(fn, inputs)helper in the test that runs the fn in-process throughDoFnRunners.simpleRunner, and to swap the 10DoFnTestercall sites over to it.