Skip to content

Port DatastoreV1Test off DoFnTester #18692

Open

Description

@kennknowles

Imported from Jira BEAM-3656. Original Jira may contain additional context.
Reported by: kenn.
Subtask of issue #18687

Activity

  1. Rishavbhattarai commented on Oct 28, 2026

    @Rishavbhattarai

    .take-issue

    I'd like to take this one too (I'm doing #18691 in #40865). DatastoreV1Test can't move to TestPipeline: the fns under test hold Mockito mocks from mockDatastoreFactory, which can't be serialized, and the tests check those mocks after the bundle runs. That's why every call sets DO_NOT_CLONE today. My plan is a small processBundle(fn, inputs) helper in the test that runs the fn in-process through DoFnRunners.simpleRunner, and to swap the 10 DoFnTester call sites over to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions