Fix download_files() in python-release.#39246
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Python release automation scripts to ensure compatibility with recent Python versions and improve the reliability of the artifact download process. By adjusting the wheel naming patterns and configuring wget to ignore robots.txt, the scripts are now better equipped to handle modern release environments. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
r: @Amar3tto |
There was a problem hiding this comment.
Code Review
This pull request updates the Python release automation utilities to support Python versions 3.10 through 3.14, updates the wheel filename patterns, adds -e robots=off to wget commands, and corrects the source distribution tarball filename. The review feedback suggests refactoring the repetitive Python version conditional block using bash parameter expansion to improve maintainability, and recommends wrapping the $RC_STAGING_URL variable in double quotes within the wget commands to prevent potential word splitting or glob expansion issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
The failed workflows are currently failing on the master branch as well, so they are unrelated to the changes introduced in this PR. |
This PR fixes the broken scripts in python release automation.
-e robots=offto wget to avoid robots.txt blocking artifact downloads.Verified that the files can be downloaded successfully with the updated
download_files()using the following script: