Skip to content

Log temp/staging location options parsing errors.#39305

Merged
tvalentyn merged 2 commits into
apache:masterfrom
tvalentyn:validations
Jul 14, 2026
Merged

Log temp/staging location options parsing errors.#39305
tvalentyn merged 2 commits into
apache:masterfrom
tvalentyn:validations

Conversation

@tvalentyn

@tvalentyn tvalentyn commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

In certain corner cases, a pipeline might be failing with unclear errors when the options are not provided correctly. These warnings help surface the issue.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the observability and user experience of pipeline option validation. By logging specific errors for temp and staging locations and providing more descriptive feedback for invalid GCS paths, it helps users identify and resolve configuration issues more efficiently.

Highlights

  • Improved Error Logging: Added explicit logging for validation errors when temp or staging locations are incorrectly configured.
  • Enhanced GCS Path Validation: Updated GCS path validation to provide clearer error messages and suggestions when the GCS object is missing.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors GCS path validation and error handling for pipeline options, adding warnings for invalid temporary and staging locations and improving the error message when a GCS path is missing an object. The review feedback suggests refining the warning logic to avoid redundant log messages when both locations are invalid, and simplifying the GCS path error message to provide a clearer suggestion to the user.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sdks/python/apache_beam/options/pipeline_options.py
Comment thread sdks/python/apache_beam/options/pipeline_options_validator.py Outdated
@tvalentyn

Copy link
Copy Markdown
Contributor Author

R: @tarun-google

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@tarun-google

Copy link
Copy Markdown
Contributor

LGTM, Thank you

@tvalentyn tvalentyn merged commit db66869 into apache:master Jul 14, 2026
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants