Deflake JmsIO authentication tests - #39920
Open
bvolpato wants to merge 1 commit into
Open
Conversation
Contributor
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JmsIOTestauthentication assertions can fail even though the broker correctly rejects unauthenticated connections. This occurred in the Java IOs precommit: ActiveMQ logged the expected authentication failure, but the test observedpeer (...) stopped.Cause
Queue reads split into multiple concurrent sources. After one reader reports the expected authentication error, DirectRunner cancels the pipeline and the fixture stops the broker while other readers are still connecting. Depending on timing, the pipeline can surface a secondary transport shutdown instead of the original security error.
Fix
Use a topic for the two authentication tests. Topics produce one
UnboundedJmsSource, removing the concurrent-failure race while preserving end-to-end pipeline coverage for missing and invalid credentials with both ActiveMQ and Qpid. Existing tests continue to cover queue splitting and queue reads.Validation
The full 70-test JMS suite passed. Both authentication tests also passed in 20 consecutive clean executions.
CHANGES.mdis unchanged because this is a test-only fix.