Repository navigation
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR resolves a test failure in HuggingfaceInferenceAPITest (and its subclass HuggingfaceInferenceAPIGCSLocationTest) by replacing sentence-transformers/all-mpnet-base-v2 with BAAI/bge-small-en-v1.5, which supports the /pipeline/feature-extraction endpoint on the Hugging Face Inference API. It also improves test stability by asserting on the embedding vector dimension and element types rather than a brittle rounded scalar value.
🔍 General Feedback
- The model replacement and updated shape/type assertion are clean, well-reasoned, and make the integration test more resilient against minor numerical variations across remote API updates.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40844 +/- ##
===========================================
+ Coverage 0 79.90% +79.90%
===========================================
Files 0 493 +493
Lines 0 83479 +83479
===========================================
+ Hits 0 66703 +66703
- Misses 0 16776 +16776
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes: #30799