Skip to content

[JDBC] Make autosharding test inserts idempotent #40857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bvolpato wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Draft

[JDBC] Make autosharding test inserts idempotent #40857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,11 @@ private PipelineResult runRead(String tableName) {
@Test
public void testWriteWithAutosharding() throws Exception {
String firstTableName = DatabaseTestHelper.getTestTableName("JDBCIT_AUTOSHARD");
DatabaseTestHelper.createTable(dataSource, firstTableName);
// JdbcIO may replay committed writes when a bundle is retried.
DatabaseTestHelper.createTable(
dataSource,
firstTableName,
Lists.newArrayList(KV.of("id", "INT PRIMARY KEY"), KV.of("name", "VARCHAR(500)")));
try {
PCollection<TestRow> dataCollection =
pipelineWrite.apply(
Expand All @@ -282,7 +286,10 @@ public void testWriteWithAutosharding() throws Exception {
.apply(
JdbcIO.<TestRow>write()
.withDataSourceConfiguration(JdbcIO.DataSourceConfiguration.create(dataSource))
.withStatement(String.format("insert into %s values(?, ?)", firstTableName))
.withStatement(
String.format(
"insert into %s values(?, ?) on conflict (id) do nothing",
firstTableName))
.withAutoSharding()
.withPreparedStatementSetter(new JdbcTestHelper.PrepareStatementFromTestRow()));

Expand Down
Loading