Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirectRunner extracts ParDo schema information and side-input mappings for every bundle. Those helpers translate the full ParDo payload each time. Profiling Nexmark's streaming queries showed repeated translation and serialization on the worker threads.
Cache the serialized metadata per applied transform. Deserialize a fresh copy for each evaluator because schema conversion functions have mutable state, and clear the cache during cleanup.
In matched warm local runs on a busy shared host, Nexmark's streaming Query 7 took 174 seconds before and 26 seconds after, excluding Gradle setup. The input, assertions, JDK and runner settings were unchanged.
The full Nexmark suite and focused DirectRunner tests covering schemas, side inputs, state and lifecycle passed locally. Formatting and compilation checks passed as well.