chore: use non-blinking software block cursor in TUI#24449
Merged
Conversation
Replace the hardware terminal cursor in ShellPanel with a software-rendered reversed-video cursor that does not blink. The hardware cursor's blink timer resets on every TamboUI frame redraw, causing it to appear half-shown on each keypress. The software cursor renders the character at the cursor position with reversed style, matching the approach already used by AiPanel. Also replace the blinking half-block (▌) cursor in CaptionOverlay with a non-blinking full-block (█) character. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
davsclaus
approved these changes
Jul 6, 2026
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 2 tested, 1 compile-only — current: 2 all testedMaveniverse Scalpel detected 3 affected modules (current approach: 2).
|
davsclaus
approved these changes
Jul 6, 2026
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
▌) cursor in CaptionOverlay with a non-blinking full-block (█) character.Changes
convertRow(buffer, offset, width, cursorCol)overload that emits the cursor column as a single reversed-video span. Pass cursor coordinates fromrenderLiveViewinstead of usingframe.setCursorPosition(). RemovelastCursorX/lastCursorYtracking fields.▌/space blink toggle with static█.Test plan
camel monitorTUI, open shell panel (F6), verify cursor is a solid non-blinking reversed blockClaude Code on behalf of Guillaume Nodet