Fix PAX protobuf array bounds warnings - #1982
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi, @krylosov-aa welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
my-ship-it
approved these changes
Sep 11, 2026
Suppress false GCC 14 array bounds warnings in protobuf 3.19 headers. Limit the suppression to protobuf includes and restore diagnostics for PAX code. See: apache#1677
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1677
What does this PR do?
GCC 14 emits false
-Warray-boundswarnings in protobuf 3.19 headers when compiling PAX.Wrap the protobuf includes in
proto_wrappers.hwith GCC diagnostic push/pop directives. This suppresses the warnings within those headers and restores diagnostics afterwards.Type of Change
Test Plan
Validated on Ubuntu 22.04 ARM64:
-O3: the three warnings inmicro_partition_stats.ccandorc_format_reader.ccdisappear, including with-Werror=array-bounds.MicroPartitionStatsTest.*:OrcTest.*pass.Rocky Linux 10 was not tested directly
Checklist