Fix private gateway ACL update using wrong SDK setter - #329
Open
sudo87 wants to merge 1 commit into
Open
Conversation
resourceCloudStackPrivateGatewayUpdate called SetNetworkid with the private gateway's own ID instead of SetGatewayid, so any acl_id update was rejected by the API with "entity does not exist". Use SetGatewayid, matching ReplaceNetworkACLListParams' actual parameter for updating a private gateway's ACL.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug in the private gateway update path where an ACL replacement request was built with the wrong CloudStack SDK parameter, causing acl_id updates to fail with “entity does not exist”.
Changes:
- Update
resourceCloudStackPrivateGatewayUpdateto callReplaceNetworkACLListParams.SetGatewayid(d.Id())instead ofSetNetworkid(d.Id()). - Align the provider’s update behavior with the CloudStack API parameter used when updating a private gateway’s ACL.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resourceCloudStackPrivateGatewayUpdate called SetNetworkid with the private gateway's own ID instead of SetGatewayid, so any acl_id update was rejected by the API with "entity does not exist". Use SetGatewayid, matching ReplaceNetworkACLListParams' actual parameter for updating a private gateway's ACL.