fix: convert device_id via int in attach_volume to avoid a panic - #342
Open
nagaboinaramgopal wants to merge 1 commit into
Open
fix: convert device_id via int in attach_volume to avoid a panic#342nagaboinaramgopal wants to merge 1 commit into
nagaboinaramgopal wants to merge 1 commit into
Conversation
device_id is a schema.TypeInt, which the SDK returns as a Go int, so the create path asserted v.(int64) and panicked with "interface conversion: interface {} is int, not int64" whenever a volume was attached with an explicit device_id. Assert int and convert to int64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
device_idoncloudstack_attach_volumeis aschema.TypeInt, which the SDK returns as a Goint, but the create path asserted it asint64:so attaching a volume with an explicit
device_idpanics the provider withinterface conversion: interface {} is int, not int64. Fixed by assertingintand converting toint64.Testing
Added a unit test
TestAttachVolumeDeviceIdDoesNotPanicthat runs the create function withdevice_idset against an unreachable endpoint. It needs no live CloudStack:It panics against the current code and passes with the fix.