fix: remove deleted resources from state instead of erroring in Read - #347
Open
nagaboinaramgopal wants to merge 1 commit into
Open
fix: remove deleted resources from state instead of erroring in Read#347nagaboinaramgopal wants to merge 1 commit into
nagaboinaramgopal wants to merge 1 commit into
Conversation
When a resource is deleted out of band, Read returned the No match found error from GetByID, failing the whole plan instead of letting Terraform recreate it. GetByID reports count 0 for a genuinely missing resource and count -1 for a transport error, so Read now clears the id and returns nil only when count is 0, and still returns the error otherwise. Applied to attach_volume, cluster, loadbalancer, physical_network, pod, secondary_storage, storage_pool, vlan_ip_range and zone. Tests cover both the deleted case (id cleared) and a transport error (id preserved).
nagaboinaramgopal
force-pushed
the
fix/read-remove-deleted-from-state
branch
from
September 7, 2026 19:57
49cccc1 to
abaa8a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a resource is deleted out of band, its Read still returned the "No match found" error from GetByID, which fails the whole plan instead of letting Terraform recreate the resource. GetByID reports count 0 for a genuinely missing resource and count -1 for a transport error, so Read now clears the id and returns nil only when count is 0, and still returns the error otherwise. Applied to the resources whose Read did not already handle this: attach_volume, cluster, loadbalancer, physical_network, pod, secondary_storage, storage_pool, vlan_ip_range, and zone.
Testing
Added a unit test
TestZoneReadRemovesDeletedFromStatecovering the zone resource as a representative case, using a stub server that returns an empty list so GetZoneByID reports count 0. It needs no live CloudStack:Before the fix Read returns the "No match found" error; after it, Read clears the id and returns nil.