ConfigureStorageAccessCmd: Allow storage access configuration on empty clusters/pods/zones

[nvazquez]

Description

This PR has the fix for the below issue:

cmk configure storageaccess operation throws an exception when zone/cluster/pod referenced in the operation is empty.

Exception: com.cloud.utils.exception.CloudRuntimeException: All hosts in the cluster are using the storage access groups

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.67%. Comparing base (4262c02) to head (aca4088).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #13551      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
- Complexity    15796    15803       +7     
============================================
  Files          5923     5923              
  Lines        533347   533347              
  Branches      65248    65254       +6     
============================================
- Hits          94253    94251       -2     
- Misses       428435   428436       +1     
- Partials      10659    10660       +1     

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.74% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm

[Pearl1594]

code lgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18479

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

clgtm

[blueorangutan]

[SF] Trillian test result (tid-16492)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53617 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13551-t16492-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[vladimirpetrov]

LGTM based on manual testing, tested with zero hosts zone, pod and cluster before and after the patch.