Fix MS Host duplicate registration#13560
Draft
Pearl1594 wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13560 +/- ##
============================================
+ Coverage 16.26% 16.71% +0.45%
- Complexity 13429 14117 +688
============================================
Files 5661 5667 +6
Lines 500010 521396 +21386
Branches 60715 69941 +9226
============================================
+ Hits 81331 87170 +5839
- Misses 409606 424543 +14937
- Partials 9073 9683 +610
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
In a Kubernetes setup with a stateful set configuration, virtual ip/mac address keeps changing while hostname is kept constant. In such a case, restarting pods results in multiple hosts registered with same hostname as we register using mac or ip address. This PR uses hostname as well to look for existing management server before registering a new one. Hostname could be null, in which case the implementation is same as what was present earlier.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?