Skip to content

UI: Fix icon for KMS#13568

Open
vishesh92 wants to merge 1 commit into
apache:mainfrom
shapeblue:fix-kms-icon
Open

UI: Fix icon for KMS#13568
vishesh92 wants to merge 1 commit into
apache:mainfrom
shapeblue:fix-kms-icon

Conversation

@vishesh92

@vishesh92 vishesh92 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes the icon for Key Management.

Before
image

After
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI review requested due to automatic review settings July 8, 2026 10:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the UI navigation configuration for the Key Management (KMS) section to use a more appropriate icon, aligning the menu visual with the feature’s purpose.

Changes:

  • Updated the KMS section icon from hdd-outlined to lock-outlined.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.46%. Comparing base (600201a) to head (475233b).

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #13568   +/-   ##
======================================
  Coverage   3.46%    3.46%           
======================================
  Files        479      479           
  Lines      41162    41162           
  Branches    7793     7793           
======================================
  Hits        1426     1426           
  Misses     39543    39543           
  Partials     193      193           
Flag Coverage Δ
uitests 3.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@weizhouapache weizhouapache added this to the 4.23.0 milestone Jul 8, 2026
@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13568 (QA-JID-959)

@weizhouapache

Copy link
Copy Markdown
Member

looks good

however, I would suggest to move the section in the left menu, I think KMS will not be used as common as Compute/Network/Storage/Images. @vishesh92

@weizhouapache weizhouapache changed the title Fix icon for KMS UI: Fix icon for KMS Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants