Skip to content

Add back missing changes from #10008 to 4.23 - #13817

Open
winterhazel wants to merge 1 commit into
apache:mainfrom
winterhazel:add-missing-10008-changes
Open

Add back missing changes from #10008 to 4.23#13817
winterhazel wants to merge 1 commit into
apache:mainfrom
winterhazel:add-missing-10008-changes

Conversation

@winterhazel

Copy link
Copy Markdown
Member

Description

This PR adds back some changes that were missing on the merge-forward of #10008.

Closes #13796.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tests are still pending.

@winterhazel winterhazel added this to the 4.23.0 milestone Aug 6, 2026
@winterhazel

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (4f11707) to head (3c21229).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13817      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
+ Complexity    19792    19787       -5     
============================================
  Files          6368     6368              
  Lines        574881   574894      +13     
  Branches      70351    70353       +2     
============================================
- Hits         112970   112963       -7     
- Misses       449639   449661      +22     
+ Partials      12272    12270       -2     
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.92% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@winterhazel winterhazel changed the title Add back missing changes from #10008 Add back missing changes from #10008 to 4.23 Aug 6, 2026
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18784

@weizhouapache

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Projects listing breaks after deleting a user (Project Admin) added to a project.

3 participants