Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ private DoubleLocaleConverter(final Double defaultValue, final Locale locale, fi
@Override
protected Double parse(final Object value, final String pattern) throws ParseException {
final Number result = super.parse(value, pattern);
if (result instanceof Long) {
return Double.valueOf(result.doubleValue());
if (result == null || result instanceof Double) {
return (Double) result;
}
return (Double) result;
return Double.valueOf(result.doubleValue());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package org.apache.commons.beanutils2.converters;

import static org.junit.jupiter.api.Assertions.assertEquals;

import org.apache.commons.beanutils2.locale.converters.DoubleLocaleConverter;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand All @@ -37,6 +39,17 @@ public void setUp() throws Exception {
expectedValue = Double.valueOf(expectedDecimalValue);
}

/**
* Passing a non-Double Number directly (e.g. Integer) must return a Double, not throw ClassCastException.
*/
@Test
void testConvertFromNonDoubleNumber() {
final DoubleLocaleConverter c = DoubleLocaleConverter.builder().get();
assertEquals(Double.valueOf(42.0), c.convert(Double.class, Integer.valueOf(42), null));
assertEquals(Double.valueOf(3.14f), c.convert(Double.class, Float.valueOf(3.14f), null));
assertEquals(Double.valueOf(100L), c.convert(Double.class, Long.valueOf(100L), null));
}

/**
* Test Converter() constructor Uses the default locale, no default value
*/
Expand Down
Loading