Skip to content

spark: support collect_list collect_set for windows execution#23281

Merged
comphead merged 2 commits into
apache:mainfrom
comphead:collect_list_over
Jul 3, 2026
Merged

spark: support collect_list collect_set for windows execution#23281
comphead merged 2 commits into
apache:mainfrom
comphead:collect_list_over

Conversation

@comphead

@comphead comphead commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Expand windows coverage to support collect_set collect_list functions.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added sqllogictest SQL Logic Tests (.slt) spark labels Jul 1, 2026
@comphead comphead changed the title faet: support collect_list for windows feat: support collect_list for windows Jul 1, 2026
@comphead comphead changed the title feat: support collect_list for windows feat: support collect_list collect_set for windows execution Jul 1, 2026
@comphead comphead changed the title feat: support collect_list collect_set for windows execution spark: support collect_list collect_set for windows execution Jul 1, 2026
Comment thread datafusion/spark/src/function/aggregate/collect.rs
Comment thread datafusion/spark/src/function/aggregate/collect.rs

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @comphead

@comphead

comphead commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @andygrove for the feedback, addressed

@comphead comphead added this pull request to the merge queue Jul 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 3, 2026
@comphead comphead added this pull request to the merge queue Jul 3, 2026
Merged via the queue into apache:main with commit 01c7527 Jul 3, 2026
35 checks passed
@comphead comphead deleted the collect_list_over branch July 3, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spark sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support collect_set and collect_set for windows execution

2 participants