chore: extend pre commit instructions for AI agents#23313
Merged
Conversation
alamb
approved these changes
Jul 3, 2026
|
|
||
| See the [Testing Quick Start](docs/source/contributor-guide/testing.md#testing-quick-start) | ||
| for the recommended pre-PR test commands. | ||
| If documentation files changed then run |
Contributor
There was a problem hiding this comment.
Other ones I use:
ci/scripts/rust_prettier.sh
ci/scripts/rust_clippy.sh
Contributor
Author
There was a problem hiding this comment.
I cant see rust_prettier 🤔
Contributor
There was a problem hiding this comment.
Sorry I meant
ci/scripts/rust_fmt.sh
Contributor
There was a problem hiding this comment.
but I see those commands are already covered above
Contributor
Author
|
Thanks @alamb for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Extend pre commit instructions for AI agents to involve contributor machine to find issues before being committed. Each commit triggers a CI which in its turn asks ASF Infra for their precious resources and if we can find and fix as early as possible, much before utilizing ASF resources, would be amazing
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?