chore: add Cargo http options to handle download errors#23314
Open
comphead wants to merge 1 commit into
Open
Conversation
2010YOUY01
reviewed
Jul 4, 2026
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
Thank you.
I'll manually rerun CI several times on this PR, to ensure it solves the issue.
| # Work around intermittent "[16] Error in the HTTP2 framing layer" | ||
| # failures from curl when cargo fetches crates from crates.io. | ||
| # Disabling HTTP/2 multiplexing forces cargo to serialize requests, | ||
| # and raising retries makes transient network hiccups self-heal. |
Contributor
There was a problem hiding this comment.
Suggested change
| # and raising retries makes transient network hiccups self-heal. | |
| # and raising retries makes transient network hiccups self-heal. | |
| # | |
| # Reference: | |
| # https://doc.rust-lang.org/cargo/reference/config.html?#httpmultiplexing | |
| # https://doc.rust-lang.org/cargo/reference/config.html?#netretry |
Let's add some reference links to the options.
However, I can't find the doc for CARGO_HTTP_RETRY, was that valid?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
CI more and more often fails with HTTP errors, during downloading from Cargo. This leads the entire CI needs to be rerun in the merge queue. Adding retry for Cargo HTTP and network settings.
Example
https://github.com/apache/datafusion/actions/runs/28677739346/job/85055401549?pr=23313
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?