fix: array_sort doesnt respect array inputs for sort order/nulls first - #24502
Draft
JSOD11 wants to merge 1 commit into
Draft
fix: array_sort doesnt respect array inputs for sort order/nulls first#24502JSOD11 wants to merge 1 commit into
JSOD11 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24502 +/- ##
==========================================
- Coverage 81.27% 81.27% -0.01%
==========================================
Files 1114 1114
Lines 393619 393619
Branches 393619 393619
==========================================
- Hits 319931 319915 -16
- Misses 54950 54964 +14
- Partials 18738 18740 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_sortdoesnt respect array inputs for sort order/nulls first #24132Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?