Skip to content

Test: pin arrow-rs to apache/arrow-rs#10719 (new PageIndex struct) - #24504

Draft
alamb wants to merge 7 commits into
apache:mainfrom
alamb:alamb/test_arrow_10719_page_index
Draft

Test: pin arrow-rs to apache/arrow-rs#10719 (new PageIndex struct)#24504
alamb wants to merge 7 commits into
apache:mainfrom
alamb:alamb/test_arrow_10719_page_index

Conversation

@alamb

@alamb alamb commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Note: this PR is for testing only and is not intended for merge

Rationale for this change

Test how the new PageIndex struct proposed in apache/arrow-rs#10719 would work with DataFusion.

See the changes needed by the API here

What changes are included in this PR?

On top of the commits from #24366:

Are these changes tested?

By existing CI

Are there any user-facing changes?

No

alamb and others added 5 commits August 14, 2026 13:00
Pin arrow/parquet crates to arrow-rs rev 901e69f913bb8a1738009218898959e8f4cd7ec8
via [patch.crates-io] until arrow 60.0.0 is released.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tore 0.14, etc)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts:
#	datafusion/core/tests/user_defined/user_defined_aggregates.rs
#	datafusion/core/tests/user_defined/user_defined_scalar_functions.rs
#	datafusion/core/tests/user_defined/user_defined_window_functions.rs
#	datafusion/ffi/src/udaf/mod.rs
#	datafusion/optimizer/src/optimizer.rs
@github-actions github-actions Bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) catalog Related to the catalog crate common Related to common crate execution Related to the execution crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate ffi Changes to the ffi crate physical-plan Changes to the physical-plan crate labels Aug 20, 2026
@codecov-commenter

codecov-commenter commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.02564% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (e2e161d) to head (e9b80d3).
⚠️ Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
datafusion/common/src/metadata.rs 67.74% 10 Missing ⚠️
datafusion/common/src/heap_size.rs 25.00% 5 Missing and 1 partial ⚠️
datafusion/proto-common/src/from_proto/mod.rs 0.00% 4 Missing and 1 partial ⚠️
datafusion/common/src/dfschema.rs 50.00% 3 Missing ⚠️
datafusion/datasource-arrow/src/file_format.rs 0.00% 2 Missing and 1 partial ⚠️
datafusion/datasource-arrow/src/source.rs 25.00% 2 Missing and 1 partial ⚠️
datafusion/datasource-parquet/src/page_filter.rs 90.32% 2 Missing and 1 partial ⚠️
datafusion/datasource-parquet/src/metadata.rs 71.42% 0 Missing and 2 partials ⚠️
datafusion/datasource-parquet/src/reader.rs 0.00% 1 Missing ⚠️
datafusion/sql/src/statement.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24504      +/-   ##
==========================================
+ Coverage   81.27%   81.30%   +0.02%     
==========================================
  Files        1114     1117       +3     
  Lines      393619   396086    +2467     
  Branches   393619   396086    +2467     
==========================================
+ Hits       319931   322038    +2107     
- Misses      54950    55218     +268     
- Partials    18738    18830      +92     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

alamb added 2 commits August 20, 2026 14:16
Replace uses of ParquetMetaData::column_index/offset_index and
ParquetColumnIndex/ParquetOffsetIndex with the new PageIndex struct
and its accessors, including PageIndex::is_complete.
@alamb
alamb force-pushed the alamb/test_arrow_10719_page_index branch from 419027d to e9b80d3 Compare August 20, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate execution Related to the execution crate ffi Changes to the ffi crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate sql SQL Planner sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants