Skip to content

[DRAFT] update PushedDown to have 3 states - #24528

Draft
jayshrivastava wants to merge 1 commit into
apache:mainfrom
jayshrivastava:js/third-filter-pushdown-state
Draft

[DRAFT] update PushedDown to have 3 states#24528
jayshrivastava wants to merge 1 commit into
apache:mainfrom
jayshrivastava:js/third-filter-pushdown-state

Conversation

@jayshrivastava

@jayshrivastava jayshrivastava commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added documentation Improvements or additions to documentation optimizer Optimizer rules core Core DataFusion crate datasource Changes to the datasource crate physical-plan Changes to the physical-plan crate labels Aug 20, 2026
@jayshrivastava jayshrivastava changed the title add 3rd filter pushdown state draft: add 3rd filter pushdown state Aug 20, 2026
@jayshrivastava jayshrivastava changed the title draft: add 3rd filter pushdown state [DRAFT] update PushedDown to have 3 states Aug 20, 2026
@github-actions

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion v55.0.0 (current)
       Built [  59.951s] (current)
     Parsing datafusion v55.0.0 (current)
      Parsed [   0.034s] (current)
    Building datafusion v55.0.0 (baseline)
       Built [  58.261s] (baseline)
     Parsing datafusion v55.0.0 (baseline)
      Parsed [   0.033s] (baseline)
    Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch)
     Checked [   0.635s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 120.562s] datafusion
    Building datafusion-datasource v55.0.0 (current)
       Built [  42.173s] (current)
     Parsing datafusion-datasource v55.0.0 (current)
      Parsed [   0.031s] (current)
    Building datafusion-datasource v55.0.0 (baseline)
       Built [  42.065s] (baseline)
     Parsing datafusion-datasource v55.0.0 (baseline)
      Parsed [   0.031s] (baseline)
    Checking datafusion-datasource v55.0.0 -> v55.0.0 (no change; assume patch)
     Checked [   0.254s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  85.658s] datafusion-datasource
    Building datafusion-datasource-parquet v55.0.0 (current)
       Built [  47.837s] (current)
     Parsing datafusion-datasource-parquet v55.0.0 (current)
      Parsed [   0.032s] (current)
    Building datafusion-datasource-parquet v55.0.0 (baseline)
       Built [  47.783s] (baseline)
     Parsing datafusion-datasource-parquet v55.0.0 (baseline)
      Parsed [   0.033s] (baseline)
    Checking datafusion-datasource-parquet v55.0.0 -> v55.0.0 (no change; assume patch)
     Checked [   0.165s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  96.886s] datafusion-datasource-parquet
    Building datafusion-physical-optimizer v55.0.0 (current)
       Built [  39.441s] (current)
     Parsing datafusion-physical-optimizer v55.0.0 (current)
      Parsed [   0.021s] (current)
    Building datafusion-physical-optimizer v55.0.0 (baseline)
       Built [  40.382s] (baseline)
     Parsing datafusion-physical-optimizer v55.0.0 (baseline)
      Parsed [   0.022s] (baseline)
    Checking datafusion-physical-optimizer v55.0.0 -> v55.0.0 (no change; assume patch)
     Checked [   0.113s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  80.937s] datafusion-physical-optimizer
    Building datafusion-physical-plan v55.0.0 (current)
       Built [  37.796s] (current)
     Parsing datafusion-physical-plan v55.0.0 (current)
      Parsed [   0.149s] (current)
    Building datafusion-physical-plan v55.0.0 (baseline)
       Built [  37.772s] (baseline)
     Parsing datafusion-physical-plan v55.0.0 (baseline)
      Parsed [   0.149s] (baseline)
    Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch)
     Checked [   0.685s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron

Failed in:
  variant PushedDown:Exact in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/filter_pushdown.rs:146
  variant PushedDown:Inexact in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/filter_pushdown.rs:150
  variant PushedDown:Unsupported in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/filter_pushdown.rs:152

--- failure enum_variant_missing: pub enum variant removed or renamed ---

Description:
A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_missing.ron

Failed in:
  variant PushedDown::Yes, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/2dedd5ae688eb3e8fff5cea485f507d572c5bedc/datafusion/physical-plan/src/filter_pushdown.rs:128
  variant PushedDown::No, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/2dedd5ae688eb3e8fff5cea485f507d572c5bedc/datafusion/physical-plan/src/filter_pushdown.rs:130

     Summary semver requires new major version: 2 major and 0 minor checks failed
    Finished [  77.643s] datafusion-physical-plan

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.26%. Comparing base (dbdc627) to head (4e3209f).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
datafusion/physical-plan/src/projection.rs 10.00% 0 Missing and 9 partials ⚠️
datafusion/datasource-parquet/src/source.rs 77.77% 2 Missing and 4 partials ⚠️
datafusion/physical-plan/src/filter_pushdown.rs 94.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24528      +/-   ##
==========================================
- Coverage   81.31%   81.26%   -0.05%     
==========================================
  Files        1117     1117              
  Lines      395911   395917       +6     
  Branches   395911   395917       +6     
==========================================
- Hits       321918   321746     -172     
- Misses      55177    55358     +181     
+ Partials    18816    18813       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change core Core DataFusion crate datasource Changes to the datasource crate documentation Improvements or additions to documentation optimizer Optimizer rules physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make filter pushdown API more precise for their purpose

2 participants