chore: migrate HawkEye to v7 - #24578
Open
tisonkun wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24578 +/- ##
========================================
Coverage 81.37% 81.38%
========================================
Files 1116 1116
Lines 397661 397960 +299
Branches 397661 397960 +299
========================================
+ Hits 323614 323868 +254
- Misses 55106 55128 +22
- Partials 18941 18964 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
[license_header.sh] `hawkeye check --config licenserc.toml`
thread 'main' panicked at hawkeye-6.5.1/src/subcommand.rs:117:52:
called `Result::unwrap()` on an `Err` value: cannot parse config file: licenserc.toml
21 | [files]
| ^^^^^ unknown field `files`
I think there should be an upgrade script for people with older versions in their system.
Co-authored-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — this is a maintenance migration for the license-header tooling.
Rationale for this change
HawkEye v7 uses a new configuration schema and removes the v6 formatter exit-code behavior. The existing integration would stop working once v7 is installed.
What changes are included in this PR?
Are these changes tested?
Yes. The repository license-header script passes with HawkEye v7 (1713 files, 0 changes, 0 conflicts, 0 unsupported). Changed YAML, TOML, Bash, and Python files also passed syntax or formatter checks as applicable.
Are there any user-facing changes?
No.