Skip to content

chore: migrate HawkEye to v7 - #24578

Open
tisonkun wants to merge 2 commits into
apache:mainfrom
tisonkun:codex/migrate-hawkeye-v7
Open

chore: migrate HawkEye to v7#24578
tisonkun wants to merge 2 commits into
apache:mainfrom
tisonkun:codex/migrate-hawkeye-v7

Conversation

@tisonkun

Copy link
Copy Markdown
Member

Which issue does this PR close?

N/A — this is a maintenance migration for the license-header tooling.

Rationale for this change

HawkEye v7 uses a new configuration schema and removes the v6 formatter exit-code behavior. The existing integration would stop working once v7 is installed.

What changes are included in this PR?

  • migrate the HawkEye configuration to v7
  • install the latest HawkEye release without pinning the tool version
  • update the license-header helper for v7 formatter semantics
  • normalize the small set of existing headers that v7 recognizes but rewrites canonically

Are these changes tested?

Yes. The repository license-header script passes with HawkEye v7 (1713 files, 0 changes, 0 conflicts, 0 unsupported). Changed YAML, TOML, Bash, and Python files also passed syntax or formatter checks as applicable.

Are there any user-facing changes?

No.

@github-actions github-actions Bot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion labels Aug 22, 2026
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.38%. Comparing base (933710d) to head (5e553c4).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #24578    +/-   ##
========================================
  Coverage   81.37%   81.38%            
========================================
  Files        1116     1116            
  Lines      397661   397960   +299     
  Branches   397661   397960   +299     
========================================
+ Hits       323614   323868   +254     
- Misses      55106    55128    +22     
- Partials    18941    18964    +23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jayzhan211 jayzhan211 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kumarUjjawal kumarUjjawal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[license_header.sh] `hawkeye check --config licenserc.toml`
  thread 'main' panicked at hawkeye-6.5.1/src/subcommand.rs:117:52:
  called `Result::unwrap()` on an `Err` value: cannot parse config file: licenserc.toml
  21 | [files]
     |  ^^^^^ unknown field `files`

I think there should be an upgrade script for people with older versions in their system.

Comment thread .github/workflows/dev.yml Outdated
@kumarUjjawal
kumarUjjawal requested a review from Jefffrey August 23, 2026 04:51
Co-authored-by: tison <wander4096@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants