fix(common): support empty struct in ScalarValue::compact and new_default - #24582
Open
unikdahal wants to merge 1 commit into
Open
fix(common): support empty struct in ScalarValue::compact and new_default#24582unikdahal wants to merge 1 commit into
unikdahal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #24581.
Rationale for this change
StructArray::newpanics for structs with zero fields because it cannot infer array length from an empty column list. This hit two code paths inScalarValue:new_defaultwhen building a default value for a zero-field struct type, andcompact_view_buffers(used byScalarValue::compact) when compacting a struct array that has zero fields but a nonzero row count.What changes are included in this PR?
ScalarValue::new_defaultandcompact_view_buffersnow special-case zero-field structs, usingStructArray::new_empty_fields(which takes an explicit length/nulls instead of inferring it from columns) rather thanStructArray::new.test_compact_empty_structcovering the panic case.Are these changes tested?
Yes, new unit test added.
Are there any user-facing changes?
No behavior change other than fixing a panic on empty-field structs.