Skip to content

bench: add window aggregate filter benchmarks - #24589

Open
lyne7-sc wants to merge 1 commit into
apache:mainfrom
lyne7-sc:bench/window-filter
Open

bench: add window aggregate filter benchmarks#24589
lyne7-sc wants to merge 1 commit into
apache:mainfrom
lyne7-sc:bench/window-filter

Conversation

@lyne7-sc

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Add benchmark coverage for evaluating the performance impact of the window aggregate filter argument evaluation changes in #24508.

What changes are included in this PR?

Adds a Criterion benchmark for window aggregates with FILTER over pre-ordered input.

It covers:

  • Cumulative and sliding frames through BoundedWindowAggExec.
  • Whole-partition frames through WindowAggExec.
  • Column, division, and power arguments.
  • Different representative FILTER selectivities.

This PR only adds benchmark coverage and does not change behavior.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Aug 23, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.38%. Comparing base (dbdc627) to head (9e87eaa).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24589      +/-   ##
==========================================
+ Coverage   81.31%   81.38%   +0.07%     
==========================================
  Files        1117     1116       -1     
  Lines      395911   397960    +2049     
  Branches   395911   397960    +2049     
==========================================
+ Hits       321918   323871    +1953     
+ Misses      55177    55129      -48     
- Partials    18816    18960     +144     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@neilconway
neilconway self-requested a review August 23, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants