Skip to content

test: cover Go serialization snapshots - #175

Merged
tisonkun merged 3 commits into
mainfrom
codex/go-snapshot-compatibility
Aug 1, 2026
Merged

test: cover Go serialization snapshots#175
tisonkun merged 3 commits into
mainfrom
codex/go-snapshot-compatibility

Conversation

@tisonkun

@tisonkun tisonkun commented Aug 1, 2026

Copy link
Copy Markdown
Member

Summary

  • update the pinned datasketches-tck revision and prepare C++, Go, and Java snapshots by default
  • add Go compatibility coverage for Bloom, CPC, Frequencies, HLL, TDigest, Theta, and Tuple
  • document Go snapshot preparation and ignore generated files

Count-min remains C++-only because the TCK currently has no Go Count-min snapshots.

Testing

  • cargo x prepare-testdata
  • cargo x check
  • cargo x test
  • cargo x lint

Closes #170

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
tisonkun requested a review from ZENOTME August 1, 2026 07:14

@proost proost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I will add go count min sketch snapshots generation too.

@tisonkun

tisonkun commented Aug 1, 2026

Copy link
Copy Markdown
Member Author

@proost Thanks for your review and information! Please let me know when it is ready so that I can test Rust's countmin deserialization works well on Go snapshots :D

@tisonkun
tisonkun merged commit 9b7fdbd into main Aug 1, 2026
10 checks passed
@tisonkun
tisonkun deleted the codex/go-snapshot-compatibility branch August 1, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run serde_test against datasketches-go snapshots

2 participants