Repository navigation
ci(builder): publish lake-builder image under the apache namespace - #9267
Merged
Merged
Conversation
build-builder.yml pushed to mericodev/lake-builder with separate credentials, so the CI toolchain image has not been updated since 2023-06-30. Use the Docker Hub credentials from build.yml and push <owner>/devlake:lake-builder-vX.Y.Z when a builder-vX.Y.Z tag is pushed. No moving latest tag; workflows will pin the version in a follow-up. Refs apache#9209
klesh
approved these changes
Oct 28, 2026
Contributor
Author
|
Thanks a lot for the quick review and merge, @klesh! To publish the first builder image under the git tag builder-v0.0.16 8d1d29a24d31f198ca006d1c71682a19032d71b7
git push upstream builder-v0.0.16The number continues after the last Once the image is on Docker Hub, I will open the small follow-up PR that switches the five |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9209 and the
dev@ discussion.
build-builder.ymlpushed the CI toolchain image tomericodev/lake-builderwith separate credentials, so that image has not been updated since
2023-06-30. As agreed on the list, it now publishes to the
apachenamespace:
build.yml(
DOCKERHUB_USER/DOCKERHUB_TOKEN/DOCKERHUB_OWNER).builder-v*git tag; pushingbuilder-v0.0.16publishes
apache/devlake:lake-builder-v0.0.16. A tag in the existingapache/devlakerepository needs no new Docker Hub repository.latesttag. Workflows will pin an explicit version.build.yml,so they are already on the ASF allowlist. The job only runs in
apache/devlake.devops/docker/lake-builder/README.mdupdated accordingly; the manualmericodevpush instructions are removed.This PR does not change any existing CI job. After it is merged, a committer
needs to push the first tag:
git tag builder-v0.0.16 && git push origin builder-v0.0.16v0.0.16 continues the numbering of the last
mericodevimage (v0.0.15).A follow-up PR then points the five
container: mericodev/lake-builder:latestlines (unit-test, e2e mysql/postgres, golangci-lint, migration-script-lint)
to
apache/devlake:lake-builder-v0.0.16.Does this close any open issues?
Part of #9209 (the follow-up PR will close it).
Other Information
Checked with
actionlint. The currentdevops/docker/lake-builder/Dockerfile(Go 1.27.3, libgit2 1.5.0, bookworm) is built in my fork's CI and runs the
unit, lint and e2e tests there.