[fix](plugin) Allow legacy unversioned authentication plugins - #67286
Open
CalvinKirs wants to merge 1 commit into
Open
[fix](plugin) Allow legacy unversioned authentication plugins#67286CalvinKirs wants to merge 1 commit into
CalvinKirs wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 16967 ms |
Contributor
TPC-DS: Total hot run time: 82569 ms |
Contributor
ClickBench: Total hot run time: 14.73 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#66211
Problem Summary:
The authentication plugin API-version gate rejects every plugin jar that does not contain
Doris-Authentication-Plugin-Api-Version. Authentication plugins were distributed before this manifest contract existed, so upgrading FE breaks those legacy artifacts even when they implement the current v1 API.This change adds an opt-in legacy mapping to the generic API gate and configures only the authentication family to treat a genuinely absent declaration as API 1.0:
Enterprise OIDC regression fixes for the Iceberg Groovy concatenation and invalid-token preflight are separate because those cases live in the enterprise-plugins repository.
Release note
Preserve compatibility with legacy unversioned authentication plugins when upgrading to a Doris FE that serves authentication plugin API 1.x.
Check List (For Author)
Test
Ran:
mvn -f fe/pom.xml -pl fe-extension-loader,fe-authentication/fe-authentication-handler -am testFocused results:
ApiVersionGateTest: 16 passedAuthenticationPluginManagerTest: 20 passedBehavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)