Skip to content

[improvement](fe) Support framed blocking Thrift servers - #67291

Open
Yukang-Lian wants to merge 2 commits into
apache:masterfrom
Yukang-Lian:codex/thrift-framed-thread-pool-helper
Open

[improvement](fe) Support framed blocking Thrift servers#67291
Yukang-Lian wants to merge 2 commits into
apache:masterfrom
Yukang-Lian:codex/thrift-framed-thread-pool-helper

Conversation

@Yukang-Lian

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: None

Problem Summary:

Custom FE server starters may need a blocking server transport while retaining the framed wire protocol used by threaded-selector clients. Previously, ThriftServer built its thread-pool server inline and only supported the unframed transport, so extensions had to duplicate Doris worker-pool construction to preserve the framed protocol.

This change adds a shared thread-pool server factory with an explicit framed-transport option. The existing unframed production path now uses the same factory. A focused end-to-end test verifies both framed and unframed RPC round trips.

Release note

Support constructing framed thread-pool Thrift servers for custom FE server starters.

Check List (For Author)

  • Test
    • Unit Test
    • Regression test
    • Manual test
    • No need to test or manual test
  • Behavior changed:
    • No.
    • Yes. Custom server starters can opt into framed transport on a blocking Thrift server.
  • Does this need documentation?
    • No.
    • Yes.

Validation: ./run-fe-ut.sh --run org.apache.doris.common.ThriftServerTest (2 tests passed).

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: None

Problem Summary: Custom FE server starters may need a blocking server transport while retaining the framed wire protocol used by threaded-selector clients. Centralize thread-pool server construction and allow callers to select framed transport without duplicating Doris worker-pool setup. The existing unframed production path now uses the same helper.

### Release note

Support constructing framed thread-pool Thrift servers for custom FE server starters.

### Check List (For Author)

- Test: Unit Test
    - Added framed and unframed end-to-end Thrift RPC round trips.
- Behavior changed: Yes. Custom server starters can opt into framed transport on a blocking Thrift server.
- Does this need documentation: No.
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants