[improvement](fe) Support framed blocking Thrift servers - #67291
Open
Yukang-Lian wants to merge 2 commits into
Open
[improvement](fe) Support framed blocking Thrift servers#67291Yukang-Lian wants to merge 2 commits into
Yukang-Lian wants to merge 2 commits into
Conversation
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: None
Problem Summary: Custom FE server starters may need a blocking server transport while retaining the framed wire protocol used by threaded-selector clients. Centralize thread-pool server construction and allow callers to select framed transport without duplicating Doris worker-pool setup. The existing unframed production path now uses the same helper.
### Release note
Support constructing framed thread-pool Thrift servers for custom FE server starters.
### Check List (For Author)
- Test: Unit Test
- Added framed and unframed end-to-end Thrift RPC round trips.
- Behavior changed: Yes. Custom server starters can opt into framed transport on a blocking Thrift server.
- Does this need documentation: No.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: None
Problem Summary:
Custom FE server starters may need a blocking server transport while retaining the framed wire protocol used by threaded-selector clients. Previously, ThriftServer built its thread-pool server inline and only supported the unframed transport, so extensions had to duplicate Doris worker-pool construction to preserve the framed protocol.
This change adds a shared thread-pool server factory with an explicit framed-transport option. The existing unframed production path now uses the same factory. A focused end-to-end test verifies both framed and unframed RPC round trips.
Release note
Support constructing framed thread-pool Thrift servers for custom FE server starters.
Check List (For Author)
Validation: ./run-fe-ut.sh --run org.apache.doris.common.ThriftServerTest (2 tests passed).