Skip to content

[fix](file cache) Avoid accessing expired HDFS profile during prefetch #67293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobhan1 wants to merge 1 commit into
base: branch-4.1
Choose a base branch
from
+3 −1
Open

[fix](file cache) Avoid accessing expired HDFS profile during prefetch #67293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion be/src/io/fs/hdfs_file_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "cpp/sync_point.h"
#include "io/fs/err_utils.h"
#include "io/hdfs_util.h"
#include "io/io_common.h"
#include "runtime/file_scan_profile.h"
#include "runtime/thread_context.h"
#include "runtime/workload_management/io_throttle.h"
Expand Down Expand Up @@ -121,7 +122,8 @@ Status HdfsFileReader::close() {

Status HdfsFileReader::read_at_impl(size_t offset, Slice result, size_t* bytes_read,
const IOContext* io_ctx) {
SCOPED_TIMER(_total_read_time);
auto* read_timer = io_ctx != nullptr && io_ctx->is_dryrun ? nullptr : _total_read_time;

@gavinchou gavinchou Aug 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems read_timer may still endup with nullptr?

SCOPED_TIMER(read_timer);
auto st = do_read_at_impl(offset, result, bytes_read, io_ctx);
if (!st.ok()) {
_handle = nullptr;
Expand Down
Loading