[opt](partial update) Select publish-conflict read strategy by update… - #67295
Open
foxtail463 wants to merge 1 commit into
Open
[opt](partial update) Select publish-conflict read strategy by update…#67295foxtail463 wants to merge 1 commit into
foxtail463 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
FixedReadPlan previously preferred the row store whenever a complete row-store column was available, regardless of the caller’s update mode. This caused fixed partial-update conflict reconstruction to materialize and decode the complete JSONB row when only the updated columns were required. However, globally switching to physical-column reads would break UPSERT semantics for values such as raw Variant data. Physical-column reads also repeated segment setup for each requested column.
Solution:
Introduce an explicit read strategy selected according to the update mode. Fixed partial updates read their current projection from physical columns, while UPSERT and historical, flexible, sequence, and row-binlog paths retain row-store-first behavior. Batch physical-column reads so each planned segment is loaded once and column iterators are created and released sequentially.