[fix](thirdparty) Keep accepting the pre-#67158 Paimon prebuilt fingerprint - #67305
Open
u70b3 wants to merge 1 commit into
Open
[fix](thirdparty) Keep accepting the pre-#67158 Paimon prebuilt fingerprint#67305u70b3 wants to merge 1 commit into
u70b3 wants to merge 1 commit into
Conversation
… fingerprint apache#67158 rotated PAIMON_LEGACY_COMPATIBLE_SEMANTIC_FINGERPRINT to the new semantic fingerprint, but the prebuilt currently shipped in the compile image is still stamped with the previous semantic marker cb82e41ba, which is in no accept list. Every CI build that merges current master and validates the prebuilt (COMPILE, performance pipelines) now aborts before compiling with "Paimon build fingerprint does not match selected inputs" and cannot rebuild inside the install-only image prefix. Dependency ordering does not change the installed artifacts, so keep the previous semantic marker accepted by listing it in PAIMON_LEGACY_BUILD_FINGERPRINTS.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
4 tasks
Contributor
TPC-H: Total hot run time: 16720 ms |
Contributor
TPC-DS: Total hot run time: 81204 ms |
Contributor
ClickBench: Total hot run time: 14.61 s |
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 16584 ms |
Contributor
TPC-DS: Total hot run time: 81310 ms |
Contributor
ClickBench: Total hot run time: 14.37 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #67158
Problem Summary:
#67158 rotated
PAIMON_LEGACY_COMPATIBLE_SEMANTIC_FINGERPRINTto the new semantic fingerprint9887cf1ec…, but did not keep the previous semantic markercb82e41ba46f534e611cdd52e66b53c227d49bf8accepted. The prebuilt currently shipped in the compile image (apache/doris:build-env-ldb-toolchain-latest, digestsha256:5d474521b72d…) is stamped with exactly that old semantic marker, and it is in no accept list. As a result, every CI build that merges current master and validates the prebuilt (COMPILE and performance pipelines) aborts before compiling:Evidence that the installed marker is
cb82e41ba…(elimination): the identical image digest passed the same pipeline one day before #67158 merged (pre-#67158 checkout: expected ==cb82e41ba== installed marker) and fails after it (installed ∉ {9887cf1ec,2bbf52e7…,dbb6ca6e…}). Example failing TeamCity builds: COMPILE 1034233 and 1034257, performance 1034228 and 1034249.Fix: since #67158 only reorders Paimon codec dependencies and does not change the installed artifacts, list the previous semantic marker in
PAIMON_LEGACY_BUILD_FINGERPRINTSso the in-circulation prebuilt stays accepted.Release note
None
Check List (For Author)
Test
arrow_paimon_fingerprint_matches cb82e41ba… $(paimon_build_fingerprint) …is rejected on master and accepted with this change; a bogus marker is still rejected in both cases.bash thirdparty/test/arrow-paimon-lifecycle-test.sh→ PASS.thirdparty/test/arrow-paimon-lifecycle-test.sh)Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)