Skip to content

[fix](fe) Accept BLOB prepared statement parameters #67306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1fanwang wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −0
Open

[fix](fe) Accept BLOB prepared statement parameters #67306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,10 @@ public static Literal getLiteralByMysqlType(MysqlColType mysqlType, boolean isUn
case MYSQL_TYPE_TIMESTAMP2:
literal = handleDateTimeLiteral(data);
break;
case MYSQL_TYPE_TINY_BLOB:
case MYSQL_TYPE_MEDIUM_BLOB:
case MYSQL_TYPE_LONG_BLOB:
case MYSQL_TYPE_BLOB:
case MYSQL_TYPE_STRING:
case MYSQL_TYPE_VARSTRING:
literal = handleStringLiteral(data);
Expand Down
26 changes: 26 additions & 0 deletions fe/fe-core/src/test/java/org/apache/doris/nereids/trees/expressions/LiteralTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package org.apache.doris.nereids.trees.expressions;

import org.apache.doris.catalog.MysqlColType;
import org.apache.doris.mysql.MysqlSerializer;
import org.apache.doris.nereids.trees.expressions.literal.ArrayLiteral;
import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral;
import org.apache.doris.nereids.trees.expressions.literal.IntegerLiteral;
Expand All @@ -36,6 +38,8 @@
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
Expand All @@ -57,6 +61,28 @@ public void testEqual() {
Assertions.assertTrue(Literal.of(false) instanceof BooleanLiteral);
}

@Test
public void testMysqlBlobParameter() {
String value = "Doris 数据";
for (MysqlColType mysqlType : Arrays.asList(
MysqlColType.MYSQL_TYPE_TINY_BLOB,
MysqlColType.MYSQL_TYPE_MEDIUM_BLOB,
MysqlColType.MYSQL_TYPE_LONG_BLOB,
MysqlColType.MYSQL_TYPE_BLOB)) {
MysqlSerializer serializer = MysqlSerializer.newInstance();
serializer.writeLenEncodedString(value);
serializer.writeInt1(0x7f);
ByteBuffer data = serializer.toByteBuffer().order(ByteOrder.LITTLE_ENDIAN);

Literal literal = Literal.getLiteralByMysqlType(mysqlType, false, data);

Assertions.assertTrue(literal instanceof StringLiteral, mysqlType.name());
Assertions.assertEquals(value, literal.getStringValue(), mysqlType.name());
Assertions.assertEquals(1, data.remaining(), mysqlType.name());
Assertions.assertEquals(0x7f, Byte.toUnsignedInt(data.get()), mysqlType.name());
}
}

@Test
public void testGetResultExpressionArrayInt() {
int num = 10;
Expand Down