[Fix](build) Restore Doris glibc-compatibility interposition with lance-c - #67312
[Fix](build) Restore Doris glibc-compatibility interposition with lance-c#67312linrrzqqq wants to merge 1 commit into
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
/review |
There was a problem hiding this comment.
Request changes: this restores the Lance compatibility link path, but the current patch has three blocking correctness problems.
Build/configuration checkpoint: the added trailing dot makes the top-level BE CMake listfile fail to parse in every configuration. After conceptually correcting that typo, I did not find a separate archive-order or final-consumer bypass: the compatibility/non-compatibility, macOS, x86_64/aarch64, sanitizer, test, benchmark, and tool link paths retain providers for the supported Lance interface.
Runtime/lifecycle checkpoint: the new PATH search can allocate 4352 bytes on the existing 1 KiB shared clone stack, corrupting the suspended parent's stack. The force-interposed posix_spawnp also routes ordinary Rust 1.91 process creation through a deliberately reduced clang-only backend that does not execute file actions, mishandles signal state/attributes, and reports clone failures incorrectly.
Compatibility checkpoint: I rechecked the direct preadv and splice syscall signatures, errno conversion, and x86_64/aarch64 argument packing; no separate ABI defect was substantiated. The cancellation delta has no demonstrated repository or pinned Lance caller, so it is not raised as a fourth issue.
Test checkpoint: existing CI/configuration and BE-UT linkage do not execute these new spawn branches. Please add a long-PATH regression and runtime coverage for pipes/dup2, cwd actions, signal mask/default attributes, and clone failure propagation as part of the fixes.
User focus: no additional user-provided focus points were supplied.
Review completion: complete after two rounds. Every candidate was independently verified, deduplicated, accepted, or dismissed with evidence, and all Round 2 reviewers reported NO_NEW_VALUABLE_FINDINGS.
e9f8042 to
318ad18
Compare
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)