Xxhash 128 - #67318
Open
philipandwaffle wants to merge 2 commits into
Open
Conversation
philipandwaffle
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
August 30, 2026 19:19
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using XXHash_64 results in a hash collision chance of ~93% with 10 billion items (based on this calculator https://kevingal.com/apps/collision.html).
Implementing the XXHash_128 function allows for more items to be hashed before a collision can realistically occur.
Issue Number: close #66704
Problem Summary:
Available hash functions with more entropy such as MD5 or SHA have issues that only xxhash_128 can solve. MD5 is slower and would effect performance when a large number of hashes are being performed. SHA results in a hash that is too large needing to use string representation, preventing its use as a table key.
Release note
XXhash_128 implemented
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)