Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/visual/symbol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,24 @@ const dataSymbolTask: StageHandler = {

function dataEach(data: SeriesData, idx: number) {
const itemModel = data.getItemModel<SymbolOptionMixin>(idx);
const rawValue = seriesModel.getRawValue(idx);
const params = seriesModel.getDataParams(idx);

for (let i = 0; i < SYMBOL_PROPS.length; i++) {
const symbolPropName = SYMBOL_PROPS[i];
const val = itemModel.getShallow(symbolPropName, true);
if (val != null) {
data.setItemVisual(idx, symbolPropName, val);
// Item-level symbol options may be callbacks just like
// series-level ones. Invoke them per data item instead
// of storing the raw function as the item visual,
// otherwise views pass a function to createSymbol and
// crash on `symbolType.indexOf`.
data.setItemVisual(
idx, symbolPropName,
isFunction(val)
? (val as unknown as SymbolCallback<CallbackDataParams>)(rawValue, params)
: val
);
}
}
}
Expand Down
111 changes: 111 additions & 0 deletions test/ut/spec/series/radar.test.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.