Skip to content

fix(dataset): print transform result with inherited header and dimensions. close #15557 #21830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityajai119 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(dataset): print transform result with inherited header and dimensions. close #15557 #21830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions src/data/helper/transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,23 +431,7 @@ function applySingleDataTransform(
})
);

if (__DEV__) {
if (transOption.print) {
const printStrArr = map(resultList, extSource => {
const pipeIndexStr = pipeIndex != null ? ' === pipe index: ' + pipeIndex : '';
return [
'=== dataset index: ' + infoForPrint.datasetIndex + pipeIndexStr + ' ===',
'- transform result data:',
makePrintable(extSource.data),
'- transform result dimensions:',
makePrintable(extSource.dimensions)
].join('\n');
}).join('\n');
log(printStrArr);
}
}

return map(resultList, function (result, resultIndex) {
const resultSourceList = map(resultList, function (result, resultIndex) {
let errMsg = '';

if (!isObject(result)) {
Expand Down Expand Up @@ -536,6 +520,24 @@ function applySingleDataTransform(
null
);
});

if (__DEV__) {
if (transOption.print) {
const printStrArr = map(resultSourceList, source => {
const pipeIndexStr = pipeIndex != null ? ' === pipe index: ' + pipeIndex : '';
return [
'=== dataset index: ' + infoForPrint.datasetIndex + pipeIndexStr + ' ===',
'- transform result data:',
makePrintable(source.data),
'- transform result dimensions:',
makePrintable(map(source.dimensionsDefine, dimDef => dimDef.name))
].join('\n');
}).join('\n');
log(printStrArr);
}
}

return resultSourceList;
}

function isSupportedSourceFormat(sourceFormat: SourceFormat): boolean {
Expand Down
25 changes: 25 additions & 0 deletions test/ut/spec/data/dataTransform.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.