Repository navigation
fix(line): keep endLabel when series.step is changed by setOption - #21835
Open
JazibAli360 wants to merge 1 commit into
Open
JazibAli360 wants to merge 1 commit into
JazibAli360 wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
LineView._newPolyline now detaches the end label from the polyline it replaces and resets
_endLabel, so_initOrUpdateEndLabelcreates a new label and attaches it to the new polyline. Added a Jest test that switchesstepback and forth with setOption.Root cause: Changing
series.step(or the coordinate system type) makes LineView build a new polyline, butthis._endLabelstill pointed to the label on the old polyline, which had been removed._initOrUpdateEndLabelsaw that the label already existed and skippedsetTextContent, so the new polyline had no end label.Fixes #21833
Fixed issues
Details
Before: What was the problem?
After
setOptionchangesseries.stepon a line series withendLabel.show: true, the end label is no longer shown.After: How does it behave after the fixing?
The end label is recreated on the new polyline and stays visible when
stepchanges, in either direction.Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information
How it was verified
npm test --silentpassesnpx jest --config test/ut/jest.config.cjspassesnpm run lintpassesnpm run checktypepassesnpm run lint --silentpassestest/ut/spec/series/line.test.ts::line should keep endLabel when step is changed by setOptionNotes for reviewers
The new test fails before the fix and passes after it, and it checks that the label is attached to the current polyline and has the right text. All 195 unit tests pass, and lint and checktype pass. This is the same cleanup that
remove()and the no-endLabel branch already do. I did not check it visually in a browser, including the labelLayout moveOverlap case or the animated update path.🤖 Generated with Claude Code by the token-tithe engine, an AI contribution donated from
leftover agent tokens. Model: claude-opus-5-5 · tokens: 457,419 (~$0.40) · second
review: none available. Happy to change anything, or to close this if it isn't a fit. To opt
this repository out of all future donations, add a file named
.github/token-tithe-ignore.